[Asterisk-code-review] res_prometheus: Add Asterisk channel metrics (...asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11351 )

Change subject: res_prometheus: Add Asterisk channel metrics
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/11351/4/res/prometheus/channels.c 
File res/prometheus/channels.c:

https://gerrit.asterisk.org/#/c/11351/4/res/prometheus/channels.c@174 
PS4, Line 174: 
> Can you reverse the order of these "for" loops so you don't have to
 > traverse the potentially large channels container multiple times?

Nevermind.  It's not worth it.  You'd have to create an array of string buffers to accumulate the output for each metric.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11351
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0db306ec94205d4f58d1e7fbabfe04b185869f59
Gerrit-Change-Number: 11351
Gerrit-PatchSet: 4
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Comment-Date: Tue, 21 May 2019 13:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190521/18a0dd02/attachment-0001.html>