[Asterisk-code-review] chan_sip, chan_iax2, chan_dahdi: Allow updating variable value. (...asterisk[master])

[Guido Falsi]

Guido Falsi has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/10930 )

Change subject: chan_sip, chan_iax2, chan_dahdi: Allow updating variable value.
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.asterisk.org/#/c/10930/12/channels/chan_iax2.c 
File channels/chan_iax2.c:

https://gerrit.asterisk.org/#/c/10930/12/channels/chan_iax2.c@10733 
PS12, Line 10733: 				peer = find_peer(iaxs[fr->callno]->peer, 1);
> Is peer guaranteed to always be set and exist? Your code assumes so, if it doesn't then this would r […]
This is why I asked if this strategy is acceptable.

I also could not find where the peer property is set, and not sure if it is always valid here. I am not even sure it is guaranteed to be set to NULL if unset, so adding a null check around that call would not be safe either.

If someone knows where the value gets set and could point me to that it would be really useful.

I'll be perform more thorough testing in the while to try to make sure by myself this strategy is acceptable, and will eventually followup. It will take me some time though.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10930
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie1897a96c82b8945e752733612ee963686f32839
Gerrit-Change-Number: 10930
Gerrit-PatchSet: 12
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 15 May 2019 13:10:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190515/a1c6e278/attachment-0001.html>