[Asterisk-code-review] stasis: Hangup channel for Local channel No such extension error (...asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11314 )

Change subject: stasis: Hangup channel for Local channel No such extension error
......................................................................


Patch Set 3:

(1 comment)

This also should be cherry-picked to the 13 and master branches.

https://gerrit.asterisk.org/#/c/11314/3/res/stasis/control.c 
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/11314/3/res/stasis/control.c@1649 
PS3, Line 1649: 
              :                 hangup_flag = ast_bridge_setup_after_goto(chan) ? AST_SOFTHANGUP_DEV : AST_SOFTHANGUP_ASYNCGOTO;
              :                 ast_channel_lock(chan);
              :                 ast_softhangup_nolock(chan, hangup_flag);
              :                 ast_channel_unlock(chan);
Formatting is off. This should be indented with tabs, and not spaces.

Also, just in case it got missed Josh mentioned putting in a comment about why the scenario occurs and what happens. I agree a comment would be good here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11314
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I15eee0b2701b69403b249d466024db4c962b6f10
Gerrit-Change-Number: 11314
Gerrit-PatchSet: 3
Gerrit-Owner: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 03 May 2019 14:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190503/3aed9f4c/attachment.html>