[Asterisk-code-review] app_queue: fixed ordering of events for queue agent dial (...asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11058 )

Change subject: app_queue: fixed ordering of events for queue agent dial
......................................................................


Patch Set 1:

> > One good place would be the documentation of the AgentConnect event, stating that "the called channel is already dialing, so events on that channel may or may not have been sent already".
> > 

The documentation for an event is generated from the XML description of the event located in the Asterisk source (usually somewhere near the top of the *.c file). If you'd like to update the documentation for an event I'd suggest making this patch do just that while dropping the change. The "AgentCalled" docs can be found in the XML in app_queue.

> > Also a general explanation of event ordering on https://wiki.asterisk.org/wiki/display/AST/Interfaces would be a good idea, as this applies both the AMI and ARI.
> 
> (sorry, meant to say AgentCalled instead of AgentConnect)

I added a few sentences to the page:

https://wiki.asterisk.org/wiki/display/AST/Interfaces

Hopefully that is what you had in mind.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11058
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id0865fb306136f30a1aa8be82f3753c47059ff2d
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 1
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 22:40:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190312/55de8a45/attachment.html>