[Asterisk-code-review] res_pjsip_diversion: Use static pj_str_t for Diversion header names (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11067 )

Change subject: res_pjsip_diversion: Use static pj_str_t for Diversion header names
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/11067/1/res/res_pjsip_diversion.c 
File res/res_pjsip_diversion.c:

https://gerrit.asterisk.org/#/c/11067/1/res/res_pjsip_diversion.c@416 
PS1, Line 416: 	ast_module_shutdown_ref(ast_module_info->self);
> Add a comment here as to why the ref has been added and not allowed to be unloaded.
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11067
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ibd6ea55ec4a604bbd43ac07f8d0b54da2c39b8b9
Gerrit-Change-Number: 11067
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 22:47:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190301/d8b2f8d0/attachment.html>