[Asterisk-code-review] Revert "pjsip_message_filter: Only do interface lookup for wildcard a... (...asterisk[16])

Joshua Colp asteriskteam at digium.com
Fri Mar 1 08:03:28 CST 2019


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/asterisk/+/11065 )

Change subject: Revert "pjsip_message_filter: Only do interface lookup for wildcard addresses."
......................................................................

Revert "pjsip_message_filter: Only do interface lookup for wildcard addresses."

This reverts commit d524ad523d0d32babba309810b5bccd09cb7f467.

Reason for revert: This causes Contact and Via headers to have the wrong
transport address.

ASTERISK-28309 #close

Change-Id: Ibba4d6176f68e39279fcd9a545f81d56e747bed8
---
M res/res_pjsip/pjsip_message_filter.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/res/res_pjsip/pjsip_message_filter.c b/res/res_pjsip/pjsip_message_filter.c
index 4b0f60d..a144213 100644
--- a/res/res_pjsip/pjsip_message_filter.c
+++ b/res/res_pjsip/pjsip_message_filter.c
@@ -237,7 +237,7 @@
 	pjsip_tpmgr_fla2_param_default(&prm);
 	prm.tp_type = tdata->tp_info.transport->key.type;
 	pj_strset2(&prm.dst_host, tdata->tp_info.dst_name);
-	prm.local_if = is_bound_any(tdata->tp_info.transport);
+	prm.local_if = PJ_TRUE;
 
 	/* If we can't get the local address use best effort and let it pass */
 	if (pjsip_tpmgr_find_local_addr2(pjsip_endpt_get_tpmgr(ast_sip_get_pjsip_endpoint()), tdata->pool, &prm) != PJ_SUCCESS) {

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11065
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibba4d6176f68e39279fcd9a545f81d56e747bed8
Gerrit-Change-Number: 11065
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190301/9f91884c/attachment.html>


More information about the asterisk-code-review mailing list