[Asterisk-code-review] app_confbridge: Attended transfer event fixup (...asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11451 )

Change subject: app_confbridge:  Attended transfer event fixup
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/11451/2/apps/app_confbridge.c 
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/11451/2/apps/app_confbridge.c@1465 
PS2, Line 1465: void confbridge_handle_atxfer(struct ast_attended_transfer_message *msg)
> As this happens asynchronously do you run risk of a race condition
 > (which you do protect against but would result in no events)
 > whereby the old channel is gone?

Yeah it's possible and I thought about continuing with only generating the join event for new_chan but i wasn't sure if that was better or worse than generating no events which is at least the current behavior.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11451
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id7709cfbceb26fbcb828b2d0d2a6b2fbeaf028e1
Gerrit-Change-Number: 11451
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 18:24:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190613/fd9979fa/attachment.html>