[Asterisk-code-review] app_amd: issue with silence suppression fixed (...asterisk[13])

[Nasir Iqbal]

Nasir Iqbal has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11394 )

Change subject: app_amd: issue with silence suppression fixed
......................................................................


Patch Set 2: Code-Review+1

> Earlier a else was added to handle AST_FRAME_NULL and such calls were marked as NOTSURE . 
Ignoring AST_FRAME_NULL or marking NOTSURE in else is the problem, cos I think AST_FRAME_NULL can be a result of silence suppression (So must treat it as silence in AMD algorithm)>
 
> Will that not serve the purpose instead of checking the AST_FRAME_NULL with VOICE and CNG FRAME which to me does exactly the same thing .
I am sorry I haven't got your point, But if we are going to take AST_FRAME_NULL as silence that it must goes with AST_FRAME_VOICE otherwise we have to repeat whole algorithm in else block.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11394
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I16ea2d6295bc99b975e8c092e5f9fbd9214debdb
Gerrit-Change-Number: 11394
Gerrit-PatchSet: 2
Gerrit-Owner: Nasir Iqbal <nasir at ictinnovations.com>
Gerrit-Reviewer: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Nasir Iqbal <nasir at ictinnovations.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 10:34:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190607/415ad4d0/attachment.html>