[Asterisk-code-review] chan_pjsip.c: Check for channel and session to not be NULL in hangup (...asterisk[16])

Richard Mudgett asteriskteam at digium.com
Thu Jun 6 11:33:28 CDT 2019


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11444 )

Change subject: chan_pjsip.c: Check for channel and session to not be NULL in hangup
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.asterisk.org/#/c/11444/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11444/1//COMMIT_MSG@7 
PS1, Line 7: chan_pjsip.c: Checked for channel and session not be be NULL in hangup
s/Checked/Check/
s/not be be/to not be/


https://gerrit.asterisk.org/#/c/11444/1/channels/chan_pjsip.c 
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/#/c/11444/1/channels/chan_pjsip.c@2349 
PS1, Line 2349: 	if(channel != NULL){
Guidelines: spacing
if (channel != NULL) {
}


https://gerrit.asterisk.org/#/c/11444/1/channels/chan_pjsip.c@2351 
PS1, Line 2351: 		if(session != NULL){
Guidelines: spacing
if (session != NULL) {
}



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11444
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I19f6566830640625e08f7b87bfe15758ad33a778
Gerrit-Change-Number: 11444
Gerrit-PatchSet: 2
Gerrit-Owner: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 16:33:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190606/71a4d8ea/attachment.html>


More information about the asterisk-code-review mailing list