[Asterisk-code-review] chan_pjsip.c: Checked for channel and session not be be NULL in hangup (...asterisk[16])

[Abhay Gupta]

Abhay Gupta has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/11444


Change subject: chan_pjsip.c: Checked for channel and session not be be NULL in hangup
......................................................................

chan_pjsip.c: Checked for channel and session not be be NULL in hangup

We have seen some rare case of segmentation fault in hangup function
and we could notice that channel pointer was NULL . Debug log shows
that there is a 200 OK answer and SIP timeout at the same time . It
looks that while the SIP session was being destroyed due to timeout
call hangup due to answer event lead to race condition and channel
is being destroyed from two different places . The check ensures we
check it not to be NULL before freeing it .

ASTERISK-25371

Change-Id: I19f6566830640625e08f7b87bfe15758ad33a778
---
M channels/chan_pjsip.c
1 file changed, 19 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/44/11444/1

diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c
index 8508631..66383d6 100644
--- a/channels/chan_pjsip.c
+++ b/channels/chan_pjsip.c
@@ -2342,18 +2342,26 @@
 	struct hangup_data *h_data = data;
 	struct ast_channel *ast = h_data->chan;
 	struct ast_sip_channel_pvt *channel = ast_channel_tech_pvt(ast);
-	struct ast_sip_session *session = channel->session;
-	int cause = h_data->cause;
+	/* Before cleaning we have to ensure that channel or its session is not NULL
+	* we have seen rare case when taskprocessor calls hangup but channel is NULL
+	* due to SIP session timeout and answer happening at the same time 
+	*/
+	if(channel != NULL){
+		struct ast_sip_session *session = channel->session;
+		if(session != NULL){
+			int cause = h_data->cause;
 
-	/*
-	 * It's possible that session_terminate might cause the session to be destroyed
-	 * immediately so we need to keep a reference to it so we can NULL session->channel
-	 * afterwards.
-	 */
-	ast_sip_session_terminate(ao2_bump(session), cause);
-	clear_session_and_channel(session, ast);
-	ao2_cleanup(session);
-	ao2_cleanup(channel);
+			/*
+	 		* It's possible that session_terminate might cause the session to be destroyed
+	 		* immediately so we need to keep a reference to it so we can NULL session->channel
+	 		* afterwards.
+	 		*/
+			ast_sip_session_terminate(ao2_bump(session), cause);
+			clear_session_and_channel(session, ast);
+			ao2_cleanup(session);
+		}
+		ao2_cleanup(channel);
+	}
 	ao2_cleanup(h_data);
 	return 0;
 }

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11444
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I19f6566830640625e08f7b87bfe15758ad33a778
Gerrit-Change-Number: 11444
Gerrit-PatchSet: 1
Gerrit-Owner: Abhay Gupta <abhay at avissol.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190606/b6675c4c/attachment-0001.html>