[Asterisk-code-review] main/udptl.c: correctly handle udptl sequence wrap around (...asterisk[13])

Kevin Harwell asteriskteam at digium.com
Mon Jul 29 18:32:02 CDT 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11575 )

Change subject: main/udptl.c: correctly handle udptl sequence wrap around
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

Thanks for the clarification.

-1 just so you notice the minor whitespace findings otherwise looks good. 

Also this needs to be cherry picked to the appropriate branches: 16, 17, 17.0, and master

https://gerrit.asterisk.org/#/c/11575/3/main/udptl.c 
File main/udptl.c:

https://gerrit.asterisk.org/#/c/11575/3/main/udptl.c@412 
PS3, Line 412: 	   to or beyond the wrap around limit & the received packet 
whitespace at end of line


https://gerrit.asterisk.org/#/c/11575/3/main/udptl.c@414 
PS3, Line 414: 	   so it has the value it would have had.  After a 16 
more whitespace at end of line



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11575
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I33caeb2bf13c574a1ebb81714b58907091d64234
Gerrit-Change-Number: 11575
Gerrit-PatchSet: 3
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 29 Jul 2019 23:32:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190729/741b991a/attachment.html>


More information about the asterisk-code-review mailing list