[Asterisk-code-review] contrib/scripts: Make spandspflow2pcap.py Python 2.7+/3.3+ compatible (...asterisk[master])

Kevin Harwell asteriskteam at digium.com
Thu Jul 25 14:09:40 CDT 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11602 )

Change subject: contrib/scripts: Make spandspflow2pcap.py Python 2.7+/3.3+ compatible
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/11602/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/11602/1//COMMIT_MSG@7 
PS1, Line 7: contrib/scripts: Make spandspflow2pcap.py Python 2.7+/3.3+ compatible
Just a suggestion, but it appears these changes include more than just compatibility updates, so more info in the commit could be beneficial.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11602
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ica182a891743017ff3cda16de3d95335fffd9a91
Gerrit-Change-Number: 11602
Gerrit-PatchSet: 1
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 19:09:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190725/69c2f204/attachment.html>


More information about the asterisk-code-review mailing list