[Asterisk-code-review] CI: Don't enable non-core modules in Certified branches (...asterisk[certified/16.3])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11625 )

Change subject: CI:  Don't enable non-core modules in Certified branches
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/11625/3/tests/CI/buildAsterisk.sh 
File tests/CI/buildAsterisk.sh:

https://gerrit.asterisk.org/#/c/11625/3/tests/CI/buildAsterisk.sh@126 
PS3, Line 126: 	else
             : 		mod_disables+="test_utils"
             : 	fi
> I noticed this 'else' (disabling of test_utils) is just in the patches for the certified branches. To keep things more inline should this also be in the other branches?

test_utils can't be run for certified branches because it depends on modules that aren't built by default for certified.  The fix isn't as straightforward as updating the module dependencies because somehow ADSI is involved so the short-term solution is to just exclude that module for certified.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11625
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.3
Gerrit-Change-Id: I0b3254c08a2479f3d39151690350cce5ce5ad766
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 18:28:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190725/7faf56bc/attachment.html>