[Asterisk-code-review] PJSIP refer: REFER response now sends 202 Accepted and NOTIFY (...testsuite[13])

Friendly Automation asteriskteam at digium.com
Tue Jul 23 08:18:58 CDT 2019


Friendly Automation has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/testsuite/+/11617 )

Change subject: PJSIP refer: REFER response now sends 202 Accepted and NOTIFY
......................................................................

PJSIP refer: REFER response now sends 202 Accepted and NOTIFY

As part of the chan_pjsip fix for Transmit REFER waiting for the REFER
result the testsuite needed to be changed.  Previously, it considered
a REFER OK immediately but it should have sent a 202 Accepted, NOTIFY
and waited for response.

ASTERISK-26968 #close
Reported-by: ASTERISK-26968

Change-Id: I55d55020ae6a9b170c70cb4ffa5c041398db9adb
---
M tests/channels/pjsip/transfers/asterisk/endpoint/refer/sipp/alice.xml
M tests/channels/pjsip/transfers/asterisk/uri/refer/sipp/alice.xml
2 files changed, 42 insertions(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/tests/channels/pjsip/transfers/asterisk/endpoint/refer/sipp/alice.xml b/tests/channels/pjsip/transfers/asterisk/endpoint/refer/sipp/alice.xml
index 26d1b95..9001091 100644
--- a/tests/channels/pjsip/transfers/asterisk/endpoint/refer/sipp/alice.xml
+++ b/tests/channels/pjsip/transfers/asterisk/endpoint/refer/sipp/alice.xml
@@ -78,6 +78,27 @@
       ]]>
   </send>
 
+  <send retrans="500">
+    <![CDATA[
+      NOTIFY sip:alice@[local_ip]:[local_port] SIP/2.0
+      [last_Via:]
+      From: alice <sip:[service]@[local_ip]:[local_port]>;tag=[call_number]
+      To: s <sip:s@[remote_ip]:[remote_port]>[peer_tag_param]
+      [last_call-ID:]
+      CSeq: 2 NOTIFY
+      Contact: <sip:alice@[local_ip]:[local_port];transport=[transport]>
+      Max-Forward: 70
+      Event: refer
+      Subscription-State: terminated
+      Content-Type: message/sipfrag
+      Content-Length: [len]
+
+      SIP/2.0 200 OK
+    ]]>
+  </send>
+
+  <recv response="200" rtd="true" />
+
   <recv request="BYE"/>
 
   <send retrans="500">
diff --git a/tests/channels/pjsip/transfers/asterisk/uri/refer/sipp/alice.xml b/tests/channels/pjsip/transfers/asterisk/uri/refer/sipp/alice.xml
index 67fa240..5cccac8 100644
--- a/tests/channels/pjsip/transfers/asterisk/uri/refer/sipp/alice.xml
+++ b/tests/channels/pjsip/transfers/asterisk/uri/refer/sipp/alice.xml
@@ -78,6 +78,27 @@
       ]]>
   </send>
 
+  <send retrans="500">
+    <![CDATA[
+      NOTIFY sip:alice@[local_ip]:[local_port] SIP/2.0
+      [last_Via:]
+      From: alice <sip:[service]@[local_ip]:[local_port]>;tag=[call_number]
+      To: s <sip:s@[remote_ip]:[remote_port]>[peer_tag_param]
+      [last_call-ID:]
+      CSeq: 2 NOTIFY
+      Contact: <sip:alice@[local_ip]:[local_port];transport=[transport]>
+      Max-Forward: 70
+      Event: refer
+      Subscription-State: terminated
+      Content-Type: message/sipfrag
+      Content-Length: [len]
+
+      SIP/2.0 200 OK
+    ]]>
+  </send>
+
+  <recv response="200" rtd="true" />
+
   <recv request="BYE"/>
 
   <send retrans="500">

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/11617
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-Change-Id: I55d55020ae6a9b170c70cb4ffa5c041398db9adb
Gerrit-Change-Number: 11617
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190723/2f38cf9a/attachment.html>


More information about the asterisk-code-review mailing list