[Asterisk-code-review] chan_pjsip: Transmit REFER waits for the REFER result setting TRANSF... (...asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11216 )

Change subject: chan_pjsip:  Transmit REFER waits for the REFER result setting TRANSFERSTATUS
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> We believe the reason the test failed is because on line 65 in 
> testsuite/tests/channels/pjsip/transfers/asterisk/endpoint/refer/sipp/alice.xml it's sending 200 OK
> It should be sending 202 Accepted in response to the REFER.
> 
> SIP/2.0 202 Accepted
> instead of
> SIP/2.0 200 OK
> 
> Also file testsuite/tests/channels/pjsip/transfers/asterisk/uri/refer/sipp/alice.xml would need the same change on the same line.
> 
> Is there a process for updating the testsuite for these changes or how do we submit these changes?

The testsuite is also in Gerrit and follows the same review process as that of Asterisk.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11216
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6c27c757c66f71e8b75e3fe49da53ebe62395dc
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 7
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 17:11:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190702/cce443ec/attachment.html>