[Asterisk-code-review] media index.c: Refactored so it doesn't cache the index (asterisk[16])
Corey Farrell
asteriskteam at digium.com
Mon Jan 28 13:04:19 CST 2019
Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10923 )
Change subject: media_index.c: Refactored so it doesn't cache the index
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.asterisk.org/#/c/10923/2/UPGRADE.txt
File UPGRADE.txt:
PS2:
> > I'm not convinced this is needed as this change doesn't cause the
> > module reload command to return an error.
>
> It is a change in behavior though so I'm going to leave it in.
That's fine but then shouldn't it be added to UPGRADE.txt in 13 as well? Possibly to UPGRADE-16.txt in master as well?
--
To view, visit https://gerrit.asterisk.org/10923
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cef327ba1b0648d85d218b70ce469ad07f4aa8d
Gerrit-Change-Number: 10923
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 19:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190128/8df81a2e/attachment.html>
More information about the asterisk-code-review
mailing list