[Asterisk-code-review] codecs.conf.sample: update codec opus docs (asterisk[16])

[George Joseph]

George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/10925 )

Change subject: codecs.conf.sample: update codec opus docs
......................................................................

codecs.conf.sample: update codec opus docs

The option value "sdp" for some of the settings was removed a while back,
however the sample conf was not updated.

This patch removes any wording with regards to the old "sdp" option value,
and adjusts the defaults to what they are now.

ASTERISK-28263

Change-Id: I41bfa44e9f69446bcc5c8fd92e3675c676fdc445
---
M configs/samples/codecs.conf.sample
1 file changed, 12 insertions(+), 14 deletions(-)

Approvals:
  Sean Bright: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/configs/samples/codecs.conf.sample b/configs/samples/codecs.conf.sample
index 8c9ce66..ef5a2f8 100644
--- a/configs/samples/codecs.conf.sample
+++ b/configs/samples/codecs.conf.sample
@@ -164,6 +164,11 @@
 
 ;============================ OPUS Section Options ============================
 ;
+; NOTE: Accurate documentation corresponding to your downloaded version of
+;       codec_opus is available from Asterisk's CLI:
+;
+;       *CLI> config show help codec_opus opus
+;
 ;[opus]
 ;type= ; Must be of type "opus" (default: "")
 ;packet_loss= ; Encoder's packet loss percentage. Can be any number between 0
@@ -182,35 +187,28 @@
 ;max_playback_rate= ; Override the maximum playback rate in the offer's SDP.
                     ; Any value between 8000 and 48000 (inclusive) is valid,
                     ; however typically it should match one of the usual opus
-                    ; bandwidths. A value of "sdp" is also allowed. When set
-                    ; to "sdp" then the value from the offer's SDP is used.
-                    ; (default: "sdp")
+                    ; bandwidths. (default: 48000)
 ;bitrate= ; Override the maximum average bitrate in the offer's SDP. Any value
           ; between 500 and 512000 is valid. The following values are also
-          ; allowed: auto, max, sdp. When set to "sdp" then the value from
-          ; the offer's sdp is used. (default: "sdp")
+          ; allowed: auto, max. (default: auto)
 ;cbr= ; Override the constant bit rate parameter in the offer's SDP. A value of
       ; 0/false/no represents a variable bit rate whereas 1/true/yes represents
-      ; a constant bit rate. A value of "sdp" is also allowed. When set to "sdp"
-      ; then the value from the offer's sdp is used. (default: "sdp")
+      ; a constant bit rate. (default: no)
 ;fec= ; Override the use inband fec parameter in the offer's SDP. A value of
       ; 0/false/no represents disabled whereas 1/true/yes represents enabled.
-      ; A value of "sdp" is also allowed. When set to "sdp" then the value from
-      ; the offer's sdp is used. (default: "sdp")
+      ; (default: yes)
 ;dtx= ; Override the use dtx parameter in the offer's SDP. A value of 0/false/no
-      ; represents disabled whereas 1/true/yes represents enabled. A value of
-      ; "sdp" is also allowed. When set to "sdp" then the value from the offer's
-      ; sdp is used. (default: "sdp")
+      ; represents disabled whereas 1/true/yes represents enabled. (default: no)
 
 ;=============================== OPUS Examples ================================
 ;
 ;[opus]
 ;type=opus
 ;max_playback_rate=8000 ; Limit the maximum playback rate on the encoder
-;fec=no ; Force no inband fec on the encoder (i.e don't use what's on the SDP)
+;fec=no ; No inband fec
 
 ;[myopus]
 ;type=opus
 ;max_bandwidth=wide ; Maximum encoded bandwidth set to wide band (0-8000 Hz
 ;                   ; audio bandwidth at 16Khz sample rate)
-;cbr=yes ; Force a constant bit rate (i.e don't use what's on the SDP)
+;cbr=yes ; Negotiate a constant bit rate

-- 
To view, visit https://gerrit.asterisk.org/10925
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: merged
Gerrit-Change-Id: I41bfa44e9f69446bcc5c8fd92e3675c676fdc445
Gerrit-Change-Number: 10925
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190128/fe3cb70e/attachment-0001.html>