[Asterisk-code-review] Test cel: Fails when DONT OPTIMIZE is off (asterisk[16])

[Chris Savinovich]

Hello Friendly Automation, Joshua C. Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10889

to look at the new patch set (#3).

Change subject: Test_cel: Fails when DONT_OPTIMIZE is off
......................................................................

Test_cel: Fails when DONT_OPTIMIZE is off

A bug in GCC causes TEST_CEL to return
failure under the following conditions:
1. TEST_FRAMEWORK on
2. DONT_OPTIMIZE off
3. Fedora and Ubuntu
4. GCC 8.2.1
5. Test name: test_cel_dial_pickup
6. There must exist a certain combination
   of multithreading.
The bug affects arithmetic calculations when
the optimization level is bigger than O1 and the
-fpartial-inline flag is on. Provided these
conditions, function ast_str_to_lower() fails to
convert to lower case due to said function being
of type force_inline.  The simple solution has
been to write a short loop that converts the
variable to lower case instead of calling function
ast_str_to_lower().
Note:1/22/2019. Changes applied to remove the
"force_inline" type from function ast_str_to_lower()

Change-Id: Ied32e0071f12ed9d5f3b4cdd878b2532a1c769d7
---
M include/asterisk/strings.h
M main/strings.c
2 files changed, 16 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/89/10889/3
-- 
To view, visit https://gerrit.asterisk.org/10889
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied32e0071f12ed9d5f3b4cdd878b2532a1c769d7
Gerrit-Change-Number: 10889
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190122/f74b4bf7/attachment-0001.html>