[Asterisk-code-review] res stasis: Auto-create context and add ability to switch ap... (asterisk[13])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10882 )

Change subject: res_stasis: Auto-create context and add ability to switch applications.
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.asterisk.org/#/c/10882/4/res/res_stasis.c
File res/res_stasis.c:

https://gerrit.asterisk.org/#/c/10882/4/res/res_stasis.c@1467
PS4, Line 1467: 	if (res != 0) {
              : 		return res;
              : 	}
Is everything cleaned up as expected here in this case?


https://gerrit.asterisk.org/#/c/10882/4/res/stasis/app.c
File res/stasis/app.c:

https://gerrit.asterisk.org/#/c/10882/4/res/stasis/app.c@315
PS4, Line 315: 		strcat(strcpy(context_name, "stasis-"), app->name);
Channeling Sean from yesterday - don't be clever. :P


https://gerrit.asterisk.org/#/c/10882/4/res/stasis/app.c@1026
PS4, Line 1026: 	strcat(strcpy(context_name, "stasis-"), name);
Ditto.



-- 
To view, visit https://gerrit.asterisk.org/10882
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c569468472dbb08905b356887373c81e03015d
Gerrit-Change-Number: 10882
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 22 Jan 2019 15:21:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190122/150e4676/attachment.html>