[Asterisk-code-review] main/cdr: Fixed cdr start overwriting (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10747 )

Change subject: main/cdr: Fixed cdr start overwriting
......................................................................


Patch Set 5:

Hi, here's more detail and more understandable log regarding AGI. I've tested with the same scenario like before.

[Jan 17 22:29:59] VERBOSE[108602] cdr.c: 0x7f0fa0001400 - Created CDR for channel PJSIP/sipp-uac-00000005
[Jan 17 22:29:59] VERBOSE[108602] cdr.c: 0x7f0fa0001400 - Transitioning CDR for PJSIP/sipp-uac-00000005 from state NONE to Single
[Jan 17 22:30:14] VERBOSE[108602] cdr.c: 0x7f0fa0001400 - Set answered time to 1547760614.046547
[Jan 17 22:30:34] VERBOSE[108602] cdr.c: 0x7f0fa0001400 - Transitioning CDR for PJSIP/sipp-uac-00000005 from state Single to Finalized
[Jan 17 22:30:34] DEBUG[108602] cdr.c: Finalized CDR for PJSIP/sipp-uac-00000005 - start 1547760599.490740 answer 1547760614.046547 end 1547760634.084737 dispo ANSWERED
[Jan 17 22:30:34] VERBOSE[108602] cdr.c: 0x7f0fa0001400 - Beginning finalize/dispatch for PJSIP/sipp-uac-00000005
[Jan 17 22:30:34] VERBOSE[108602] cdr.c: 0x7f0fa0001400 - Dispatching CDR for Party A PJSIP/sipp-uac-00000005, Party B <none>


The cdr's status changing is, 
NONE -> Single -> Finalized
which is OK to create only 1 CDR for this.

And, I've tested another scenario which is includeing queue(). The issue what you mention above thing, the reason of creating more than 2 cdrs, was queue().
Because queue generated call to the other endpoit, it makes more cdrs.
------------------------------------------------

Anyways, unlike the AGI, when the channel entered to the ARI, the cdr status changed to the Dial and then changed to DialPending.

None -> Single -> Dial -> DialPending -> Single -> Fianalized

So, at this point, I don't get it why cdr status changed to the Dial even it doesn't dialing. Just entered to the ARI.
It should not change the status.

But I couldn't make sure I'm right or not at the moment.
However, I think the entering ARI must not change the status to the Dial now.

I was focused on to fix the time-overwrting problem. But it was not the real problem.

If you guys agreed with this, I would like to change it to make the entering ARI can not change the status to DIAL.


-- 
To view, visit https://gerrit.asterisk.org/10747
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I921bc04064b6cff1deb2eea56a94d86489561cdc
Gerrit-Change-Number: 10747
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <sungtae at messagebird.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: sungtae kim <sungtae at messagebird.com>
Gerrit-Comment-Date: Thu, 17 Jan 2019 22:00:16 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190117/4ed9fa81/attachment-0001.html>