[Asterisk-code-review] pbx dundi: added IPv4/IPv6 dual bind support to DUNDi (asterisk[16])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10860 )

Change subject: pbx_dundi: added IPv4/IPv6 dual bind support to DUNDi
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

The DUNDi documentation also needs to be updated with this new functionality.

https://gerrit.asterisk.org/#/c/10860/2/pbx/pbx_dundi.c
File pbx/pbx_dundi.c:

https://gerrit.asterisk.org/#/c/10860/2/pbx/pbx_dundi.c@186
PS2, Line 186: static int netsocket = -1;
             : static int netsocket2 = -1;
It should be documented here in comment what each socket is for


https://gerrit.asterisk.org/#/c/10860/2/pbx/pbx_dundi.c@2221
PS2, Line 2221: 	if (!socket_read_id2) {
This is the reversed logic to what it should be


https://gerrit.asterisk.org/#/c/10860/2/pbx/pbx_dundi.c@4976
PS2, Line 4976: 		} else if (!strcasecmp(v->name, "bindaddr2")) {
This isn't a particularly good name for this. This is really a bind address for IPv6, while bindaddr is for IPv4.


https://gerrit.asterisk.org/#/c/10860/2/pbx/pbx_dundi.c@5195
PS2, Line 5195: 			ast_log(LOG_ERROR, "bind & bind2 ip protocol should be different\n");
This should be more explicit about what is needed. You have explicit logic that expects the second one to be IPv6.



-- 
To view, visit https://gerrit.asterisk.org/10860
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d6e6b52dbe51415046bb3953fd16f5b421bc2e1
Gerrit-Change-Number: 10860
Gerrit-PatchSet: 2
Gerrit-Owner: Kirsty Tyerman <kirsty.tyerman at boeing.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 14:27:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190111/003dc983/attachment.html>