[Asterisk-code-review] http.c: Support separated HTTP request (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10869 )

Change subject: http.c: Support separated HTTP request
......................................................................


Patch Set 5:

(1 comment)

> Sorry for being dense.  I am just not understanding clearly the
 > terminology being used. I know I still have lots to learn.  I tried
 > looking up "seperated HTTP request" and am not finding anything.  I
 > was just trying to clarify what you meant rather than assuming what
 > it is that you are doing.  If I understand correctly, you are
 > trying to make sure Asterisk receives the entire body before moving
 > on.  Is that correct?
 > 
 > There is a comment that the stream is in exclusive mode.  Will this
 > change have side affects when receiving the message body slowly? 
 > Especially if you are increasing the acceptable limit on the
 > content's length.

There's no stupid question, besides, dense is my job. ;)

https://gerrit.asterisk.org/#/c/10869/4/main/http.c
File main/http.c:

https://gerrit.asterisk.org/#/c/10869/4/main/http.c@90
PS4, Line 90: /*! Maximum response body length. */
> This is not actually a maximum, it's being used to create an initial allocation size of an ast_str. […]
NP. Fixed it. :)



-- 
To view, visit https://gerrit.asterisk.org/10869
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48a401aa64a21c3b37bf3cb4e0486d64b7dd8aa1
Gerrit-Change-Number: 10869
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 07:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190111/514ae2ce/attachment.html>