[Asterisk-code-review] http.c: Support separated HTTP request (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10869 )

Change subject: http.c: Support separated HTTP request
......................................................................


Patch Set 4:

(1 comment)

> @corey Some of ARI response requires more than 4k contents length.
 > For example, /ari/recording/stored. What can I do to support this?

I'd prefer you update the name of the define and related comment before I give +1.

https://gerrit.asterisk.org/#/c/10869/4/main/http.c
File main/http.c:

https://gerrit.asterisk.org/#/c/10869/4/main/http.c@90
PS4, Line 90: /*! Maximum response body length. */
This is not actually a maximum, it's being used to create an initial allocation size of an ast_str.  ast_str_set with the second argument 0 will reallocate the ast_str if it's not large enough.

Maybe a better name for the define would be INITIAL_RESPONSE_BODY_BUFFER?



-- 
To view, visit https://gerrit.asterisk.org/10869
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48a401aa64a21c3b37bf3cb4e0486d64b7dd8aa1
Gerrit-Change-Number: 10869
Gerrit-PatchSet: 4
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 15:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190110/2a22bc8b/attachment-0001.html>