[Asterisk-code-review] pbx dundi: added support for PJSIP in dundi mappings (asterisk[15])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10855 )

Change subject: pbx_dundi: added support for PJSIP in dundi mappings
......................................................................


Patch Set 1: Code-Review-2

Asterisk 15 is in security fix only state so this change can not be merged into it. The current supported branches are 13, 16, and master.

In general, though, I don't think this is the correct approach for supporting PJSIP. This is because unlike other channel drivers you can not simply dial a target at an IP address. As it is this change would only work if an endpoint of that already existed. If it did not, then it would fail.

I think a configuration option on the side doing the lookup would need to be present to allow a PJSIP endpoint to be specified when constructing the appropriate Dial line.


-- 
To view, visit https://gerrit.asterisk.org/10855
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd2d7637e25c5c0a5aa1f3254bab641b1bfe133
Gerrit-Change-Number: 10855
Gerrit-PatchSet: 1
Gerrit-Owner: Kirsty Tyerman <kirsty.tyerman at boeing.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 08 Jan 2019 11:27:01 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190108/05a36cf1/attachment.html>