[Asterisk-code-review] stasis.c: Added topic all container (asterisk[16])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/11013 )

Change subject: stasis.c: Added topic_all container
......................................................................


Patch Set 1:

> > Patch Set 1:
 > >
 > > > I've confirmed that this does seem to break CDR and CEL on my
 > own
 > >  > system too. 16 branch is fine, but with this change it is not.
 > >
 > > Could this be related to the -fpartial-inlining issue? 
 > https://gerrit.asterisk.org/10997 was not reverted in master.
 > 
 > That I do not know, but from my quick testing this morning it only
 > occurs with this patch included.

Hi Joshua,

I've checked each of previous commits to the Asterisk-16. Therefore, I found after below commit, all the cdr test was actually failed. I didn't check that why yet, but the thing is, it was wrong since long time ago not only for this time.

c2e6efa63d1fce268455ea0552c9725677f20e0b

https://gerrit.asterisk.org/#/c/asterisk/+/10385/

For example, this test looks ok in jenkins, 
https://jenkins2.asterisk.org/job/asterisk-unittests/job/16/623/consoleFull

But in the manual test, it returns fail.

Asterisk Ready.
*CLI> core show version
Asterisk GIT-16-2f8def1453 built by pchero @ debian on a x86_64 running Linux on 2019-02-20 23:28:47 UTC
*CLI> test execute category /main/cdr/ name test_cdr_fork_cdr
Running all available tests matching category /main/cdr/ and name test_cdr_fork_cdr

START  /main/cdr/ - test_cdr_fork_cdr 
[Feb 21 02:15:45] NOTICE[90910]: cdr.c:4501 cdr_toggle_runtime_options: CDR simple logging enabled.
0x7f6d34000f30 - Created CDR for channel CDRTestChannel/Alice
0x7f6d34000f30 - Transitioning CDR for CDRTestChannel/Alice from state NONE to Single
0x55dfd5ae2f90 - Created CDR for channel CDRTestChannel/Alice
0x55dfd5ae2f90 - Transitioning CDR for CDRTestChannel/Alice from state NONE to Single
0x55dfd5ae6bb0 - Created CDR for channel CDRTestChannel/Alice
0x55dfd5ae6bb0 - Transitioning CDR for CDRTestChannel/Alice from state NONE to Single
0x7f6d34000f30 - Transitioning CDR for CDRTestChannel/Alice from state Single to Finalized
0x55dfd5ae2f90 - Transitioning CDR for CDRTestChannel/Alice from state Single to Finalized
0x55dfd5ae6bb0 - Set answered time to 1550711746.223075
Verifying expected record CDRTestChannel/Alice, <none>
Finished expected record CDRTestChannel/Alice, <none>
0x55dfd5ae7d10 - Created CDR for channel CDRTestChannel/Alice
0x55dfd5ae7d10 - Transitioning CDR for CDRTestChannel/Alice from state NONE to Single
0x55dfd5ae7d10 - Set answered time to 1550711747.220814
0x55dfd5ae6bb0 - Transitioning CDR for CDRTestChannel/Alice from state Single to Finalized
0x55dfd5ae7900 - Created CDR for channel CDRTestChannel/Alice
0x55dfd5ae7900 - Transitioning CDR for CDRTestChannel/Alice from state NONE to Single
0x55dfd5ae7900 - Set answered time to 1550711747.220864
0x55dfd5ae7d10 - Transitioning CDR for CDRTestChannel/Alice from state Single to Finalized
0x55dfd5ae7900 - Transitioning CDR for CDRTestChannel/Alice from state Single to Finalized
0x7f6d34000f30 - Beginning finalize/dispatch for CDRTestChannel/Alice
0x7f6d34000f30 - Dispatching CDR for Party A CDRTestChannel/Alice, Party B <none>
[test_cdr.c:verify_mock_cdr_record:328]: Unable to find actual CDR record at 1
END    /main/cdr/ - test_cdr_fork_cdr Time: 6999ms Result: FAIL

1 Test(s) Executed  0 Passed  1 Failed


-- 
To view, visit https://gerrit.asterisk.org/11013
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
Gerrit-Change-Number: 11013
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 01:17:03 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190220/3e17e500/attachment.html>