[Asterisk-code-review] chan pjsip: Changed to continued after invalid media for pjs... (asterisk[master])

[Friendly Automation]

Friendly Automation has submitted this change and it was merged. ( https://gerrit.asterisk.org/11000 )

Change subject: chan_pjsip: Changed to continued after invalid media for pjsip show channelstats
......................................................................

chan_pjsip: Changed to continued after invalid media for pjsip show channelstats

Currently, the pjsip show channelstats cli does not show channel's
stats after hits the invalid channel info. This makes hard to use
this cli. Changed to keep iterate after hits the invalid channel
info.

ASTERISK-28292

Change-Id: I3efdff1c9e1b1efd3c971fb82ae77aa133a6f43c
---
M channels/pjsip/cli_commands.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Joshua C. Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/channels/pjsip/cli_commands.c b/channels/pjsip/cli_commands.c
index 2ce2369..3250607 100644
--- a/channels/pjsip/cli_commands.c
+++ b/channels/pjsip/cli_commands.c
@@ -352,7 +352,7 @@
 
 	if (!channel) {
 		ast_str_append(&context->output_buffer, 0, " %s not valid\n", snapshot->base->name);
-		return -1;
+		return 0;
 	}
 
 	ast_channel_lock(channel);
@@ -362,7 +362,7 @@
 		ast_str_append(&context->output_buffer, 0, " %s not valid\n", snapshot->base->name);
 		ast_channel_unlock(channel);
 		ao2_cleanup(channel);
-		return -1;
+		return 0;
 	}
 
 	media = session->active_media_state->default_session[AST_MEDIA_TYPE_AUDIO];
@@ -370,7 +370,7 @@
 		ast_str_append(&context->output_buffer, 0, " %s not valid\n", snapshot->base->name);
 		ast_channel_unlock(channel);
 		ao2_cleanup(channel);
-		return -1;
+		return 0;
 	}
 
 	rtp = ao2_bump(media->rtp);

-- 
To view, visit https://gerrit.asterisk.org/11000
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3efdff1c9e1b1efd3c971fb82ae77aa133a6f43c
Gerrit-Change-Number: 11000
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190220/ebe09382/attachment.html>