[Asterisk-code-review] release summary: Don't update issue fixed version. (repotools[master])

[Kevin Harwell]

Kevin Harwell has submitted this change and it was merged. ( https://gerrit.asterisk.org/10992 )

Change subject: release_summary: Don't update issue fixed version.
......................................................................

release_summary: Don't update issue fixed version.

When creating a release summary it should do just that, and
not update the fixed version for each issue. Updating is
problematic because the process can later be interrupted
and the release process stopped - yet the fix version would
still have been applied.

Change-Id: Ic2fe07c008b7db06c4a93efdf91735863ad72b05
---
M release_summary.py
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved; Approved for Submit



diff --git a/release_summary.py b/release_summary.py
index 9b4a77d..193ac95 100755
--- a/release_summary.py
+++ b/release_summary.py
@@ -15,7 +15,7 @@
 from optparse import OptionParser
 from progressbar import ProgressBar
 
-from digium_jira import get_jira_client, DigiumJiraVersion
+from digium_jira import get_jira_client
 from digium_jira_user import AsteriskUser
 from digium_git import get_repo, DigiumGitRepo
 
@@ -251,12 +251,6 @@
             pbar.maxval = len(self.raw_log_messages)
             pbar.start()
 
-        # Go ahead and update the fixedVersion on the issue while processing
-        # the release summary. If the version has already been applied it
-        # won't do it again.
-        djv = DigiumJiraVersion(self.options.version,
-                                self.options.project, self.jira)
-
         for i, log_message in enumerate(self.raw_log_messages):
 
             if log_message.raw and len(log_message.raw.parents) > 1:
@@ -309,7 +303,6 @@
                     status = str(issue.fields.status).lower()
                     if status == 'closed' or status == 'complete':
                         issue_dict = self.closed_issues
-                        djv.apply_version(issue)
                     else:
                         issue_dict = self.open_issues
 

-- 
To view, visit https://gerrit.asterisk.org/10992
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2fe07c008b7db06c4a93efdf91735863ad72b05
Gerrit-Change-Number: 10992
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190219/5799ae7f/attachment.html>