[Asterisk-code-review] taskprocessor: Enable subsystems and overload by subsystem (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/11001 )

Change subject: taskprocessor:  Enable subsystems and overload by subsystem
......................................................................


Patch Set 6:

(12 comments)

recheck

https://gerrit.asterisk.org/#/c/11001/3/CHANGES
File CHANGES:

https://gerrit.asterisk.org/#/c/11001/3/CHANGES@20
PS3, Line 20: completely 
> sp
Done


https://gerrit.asterisk.org/#/c/11001/3/CHANGES@22
PS3, Line 22:    taskprocessor overloads.
> blob
Done


https://gerrit.asterisk.org/#/c/11001/3/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/#/c/11001/3/configs/samples/pjsip.conf.sample@1119
PS3, Line 1119:                 : "global": (default) Any taskprocessor overload will trigger.
> Need to note that this value is risky to use as not backing off on new work puts your system at risk […]
Done


https://gerrit.asterisk.org/#/c/11001/3/configs/samples/pjsip.conf.sample@1121
PS3, Line 1121:                 ; "none":  No overload detection will be performed.
> Need to note that this is a compromise. […]
Done


https://gerrit.asterisk.org/#/c/11001/3/contrib/ast-db-manage/config/versions/f3c0b8695b66_taskprocessor_overload_trigger.py
File contrib/ast-db-manage/config/versions/f3c0b8695b66_taskprocessor_overload_trigger.py:

https://gerrit.asterisk.org/#/c/11001/3/contrib/ast-db-manage/config/versions/f3c0b8695b66_taskprocessor_overload_trigger.py@27
PS3, Line 27: 
> blob
Done


https://gerrit.asterisk.org/#/c/11001/3/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/11001/3/main/stasis.c@682
PS3, Line 682: 		ast_taskprocessor_build_name(tps_name, sizeof(tps_name), "stasis/%c:%s",
> Suggest renaming these stasis subscription taskprocessors to: […]
Done


https://gerrit.asterisk.org/#/c/11001/3/main/taskprocessor.c
File main/taskprocessor.c:

https://gerrit.asterisk.org/#/c/11001/3/main/taskprocessor.c@94
PS3, Line 94: Anything 
> sp
Done


https://gerrit.asterisk.org/#/c/11001/3/main/taskprocessor.c@594
PS3, Line 594: 	idx = AST_VECTOR_GET_INDEX(&overloaded_subsystems, subsystem, subsystem_match);
> AST_VECTOR_APPEND can fail and leak s. […]
Done


https://gerrit.asterisk.org/#/c/11001/3/main/taskprocessor.c@624
PS3, Line 624: 		AST_VECTOR_RW_UNLOCK(&overloaded_subsystems);
> The changes to this function are not good. […]
Done


https://gerrit.asterisk.org/#/c/11001/3/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/11001/3/res/res_pjsip.c@1847
PS3, Line 1847: 				<configOption name="taskprocessor_overload_trigger">
> Specifying a default here is useless.  Nothing uses the default value specified here.
Done


https://gerrit.asterisk.org/#/c/11001/3/res/res_pjsip.c@5011
PS3, Line 5011: 	}
> Change the passed name string from "SIP" to "pjsip" and fix ast_threadpool_create() to create taskpr […]
Done


https://gerrit.asterisk.org/#/c/11001/3/res/res_pjsip/config_global.c
File res/res_pjsip/config_global.c:

https://gerrit.asterisk.org/#/c/11001/3/res/res_pjsip/config_global.c@705
PS3, Line 705: 		overload_trigger_map[DEFAULT_TASKPROCESSOR_OVERLOAD_TRIGGER],
> one too many indention tabs
Done



-- 
To view, visit https://gerrit.asterisk.org/11001
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c19068bb2fc26610a9f0b8624bdf577a04fcd56
Gerrit-Change-Number: 11001
Gerrit-PatchSet: 6
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 18:29:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190219/406e3d00/attachment.html>