[Asterisk-code-review] force inline: remove all force inline from asterisk. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10936 )

Change subject: force_inline: remove all force_inline from asterisk.
......................................................................


Patch Set 4:

> I wouldn't count on GCC fixing this one anytime soon.  to begin
 > with, some people don't even think it is a bug. Add to that on
 > investigating I found the issue goes back to posts in 2012, meaning
 > it keeps coming back. In addition, it is very hard to replicate,
 > being so far test_cel the only module that causes the level of
 > multithreading that triggers the bug. What if it is caused by the
 > way test_cel loads? If we apply -fno-partial-inline it will likely
 > stay there forever, potentially slowing down Asterisk.

My concern is that this patch is completely disabling inlining for some tiny functions.

Someone had asked why we couldn't just remove the `force_inline` but leave these in the headers, it was pointed out that GCC would complain about the functions being unused.  Couldn't we just replace `force_inline` with `attribute_unused`?  This way GCC won't complain about the unused static functions and we'd still allow it to be inlined if GCC wants.


-- 
To view, visit https://gerrit.asterisk.org/10936
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9
Gerrit-Change-Number: 10936
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Comment-Date: Mon, 18 Feb 2019 16:54:58 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190218/293f0717/attachment.html>