[Asterisk-code-review] force inline: remove all force inline from asterisk. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10939 )

Change subject: force_inline: remove all force_inline from asterisk.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/10939/2/include/asterisk/strings.h
File include/asterisk/strings.h:

https://gerrit.asterisk.org/#/c/10939/2/include/asterisk/strings.h@94
PS2, Line 94: int attribute_pure ast_begins_with(const char *str, const char *prefix);
> I think this an ABI breaking change. […]
Sort of.

Pre-compiled modules built before this patch would still work with Asterisk versions containing this patch.  There is no ABI breakage in that direction.  Pre-compiled modules built with this patch would not work with older Asterisk versions that don't have this patch.  There are numerous cases where a pre-compiled module cannot work with older versions of Asterisk in the same branch simply because a new function was added in newer Asterisk versions.

I think functions declared with force_inline forces the compiler to inline functions regardless of complexity so I don't think the compiler would ever create a real function.  IIRC the compiler has to create a real function for functions declared inline in case the compiler decides to not inline the function.



-- 
To view, visit https://gerrit.asterisk.org/10939
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9
Gerrit-Change-Number: 10939
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 13 Feb 2019 17:09:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190213/1ad9adc5/attachment.html>