[Asterisk-code-review] build: Revise CHANGES and UPGRADE.txt handling. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10943 )

Change subject: build: Revise CHANGES and UPGRADE.txt handling.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10943/1/CHANGES
File CHANGES:

https://gerrit.asterisk.org/#/c/10943/1/CHANGES@9
PS1, Line 9: ==============================================================================
You need to add a stern warning that this file is now auto-generated and to NOT make changes to it.  The UPGRADE files should be annotated as well.


https://gerrit.asterisk.org/#/c/10943/1/doc/CHANGES-staging/README
File doc/CHANGES-staging/README:

https://gerrit.asterisk.org/#/c/10943/1/doc/CHANGES-staging/README@8
PS1, Line 8: If there are multiple items that need documenting, each can
           : be separated with a subject line
I'd remove this and force folks to put each change in a separate file or make it clear that any changes in a single file should be part of the same commit so we don't wind up back where we started with merge/cherry-pick issues.


https://gerrit.asterisk.org/#/c/10943/1/doc/UPGRADE-staging/README
File doc/UPGRADE-staging/README:

https://gerrit.asterisk.org/#/c/10943/1/doc/UPGRADE-staging/README@7
PS1, Line 7: If there
           : are multiple items that need documenting, each can be separated with a subject
           : line, which should always start with "SUBJECT:"
Same comment as the CHANGES README



-- 
To view, visit https://gerrit.asterisk.org/10943
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cf4b569321c88155a65e9b0b80f6d58075dd47
Gerrit-Change-Number: 10943
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 14:59:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190204/b512a61d/attachment.html>