[Asterisk-code-review] chan_sip: voice frames are no longer transmitted after emitting a COLP (asterisk[master])

Friendly Automation asteriskteam at digium.com
Mon Dec 30 15:17:54 CST 2019


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/13367 )

Change subject: chan_sip: voice frames are no longer transmitted after emitting a COLP
......................................................................

chan_sip: voice frames are no longer transmitted after emitting a COLP

The SIP transaction state was reset when emitting an UPDATE or a re-INVITE
related to a COLP, preventing RTP packets to be emitted.

ASTERISK-28647

Change-Id: Ie7a30fa7a97f711e7ba6cc17f221a0993d48bd8b
---
M channels/chan_sip.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Joshua C. Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 72b2851..3ed06aa 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -15746,7 +15746,6 @@
 			initialize_initreq(p, &req);
 			p->lastinvite = p->ocseq;
 			ast_set_flag(&p->flags[0], SIP_OUTGOING);
-			p->invitestate = INV_CALLING;
 			send_request(p, &req, XMIT_CRITICAL, p->ocseq);
 		} else if ((is_method_allowed(&p->allowed_methods, SIP_UPDATE)) && (!ast_strlen_zero(p->okcontacturi))) {
 			reqprep(&req, p, SIP_UPDATE, 0, 1);

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13367
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie7a30fa7a97f711e7ba6cc17f221a0993d48bd8b
Gerrit-Change-Number: 13367
Gerrit-PatchSet: 1
Gerrit-Owner: Jean Aunis - Prescom <jean.aunis at prescom.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191230/2cca4b63/attachment-0001.html>


More information about the asterisk-code-review mailing list