[Asterisk-code-review] confbridge: Add support for specifying maximum sample rate. (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13441 )

Change subject: confbridge: Add support for specifying maximum sample rate.
......................................................................


Patch Set 3: Code-Review+2

> Patch Set 3:
> 
> > Patch Set 3: Code-Review-1
> > 
> > Patch looks fine, just giving -1 so you notice the following:
> > 
> > This feature needs a test. Should be possible to write one?
> 
> I gave that some thought originally and didn't really come up with a way to. It's all an internal implementation detail, so visibility into what has happened doesn't really exist. I'll give it some further thought though.

Hrm yeah true. Thinking more I think a test for this would be challenging. This can go ahead and go in, and if for some reason you do think of a way to easily write a test it can always be added later.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13441
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Idff80896ccfb8a58a816e4ce9ac4ebde785963ee
Gerrit-Change-Number: 13441
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua C. Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 19 Dec 2019 15:08:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191219/7bc62ad9/attachment.html>