[Asterisk-code-review] res_fax: wrap v21 detected Asterisk initiated negotiation with config... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13430 )

Change subject: res_fax: wrap v21 detected Asterisk initiated negotiation with config option
......................................................................


Patch Set 1: Code-Review+1

> Patch Set 1:
> 
> > Patch Set 1: Code-Review-1
> > 
> > Can you update the res_fax.conf.sample config file as well?
> 
> Probably shouldn't. res_fax.conf.sample only lists those items set for general options, which are used as defaults for some things. Currently this new option cannot be set in the res_fax.conf file. It is set using something like the FAXOPT function similar to other options.

Oh duh.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13430
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I5deb875f3485e20bc75119ec743090655d864a1a
Gerrit-Change-Number: 13430
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 18 Dec 2019 15:58:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191218/1af99f6c/attachment-0001.html>