[Asterisk-code-review] res_pjsip_messaging: Rewrite To: to normalize recipient (asterisk[13])

[Brian J. Murrell]

Brian J. Murrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13065 )

Change subject: res_pjsip_messaging:  Rewrite To: to normalize recipient
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review-1
> 
> I'm a little concerned...
> 1.  I thought we talked in the issue about making this a configurable option.

I guess I thought you meant that configuring one's systemname to be the name of the PBX was an option to doing that.  Clearly it wasn't.  What other kind of mechanism were you thinking of?

> 2.  System Name isn't guaranteed to be a FQDN if autosystemname=no.  systemname="My Pbx" is perfectly valid.

Fair enough.  But I understood that if one wants this feature of sending MESSAGEs with the recipient host unrewritten, then one needs to name one's PBX what they want the recipient to be.  Again, clearly that's not what you were looking for so perhaps some clarification of what would be an acceptable mechanism would be useful.

> 3.  If the pbx is behind a NAT, the FQDN might not be something an admin wants to expose.

I think they'd have to accept that that's what happens if they want this recipient non-rewriting feature.  If they don't want it exposed they wouldn't want the feature then right?

> 4.  What happens when the destination isn't an end-user?  If we send the MESSAGE to a provider do we want the To host to be the pbx?

In my tests here, when I send a message from my client, in response to a MESSAGE from outside of my system (i.e. from another telco) and it comes from my provider, when I reply to it, it goes to AAAEEE1234 at my.providers.domain.  I think that's what we are looking for.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13065
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iab8d472081d22ed80a3abf3b34833d898306ac8e
Gerrit-Change-Number: 13065
Gerrit-PatchSet: 2
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 17 Dec 2019 14:57:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191217/08ec7d65/attachment-0001.html>