[Asterisk-code-review] app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13472 )

Change subject: app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > Patch Set 1:
> > > 
> > > (1 comment)
> > > 
> > > Sorry for this, I hoped I could fix module declaration for Asterisk 13 with an additional Patch Set, but I got a anthentication error whne trying to recover current asterisk-13 Gerrit work.
> > > 
> > > Redone from scratch for asterisk-13.
> > 
> > Gerrit cares about the Change-Id value.  If you change the commit message on your local v13 patch to have the same change Id as this review, then it will go to this review.  You can then abandon the duplicate you created that has the different Change-Id.
> 
> I have just tried to run "commit -a --amend" on my local asterisk-13 git repo, change Change-Id and run "git review 13", but I now get:
> "! [remote rejected]       HEAD -> refs/for/13%topic=ASTERISK-28636 (change https://gerrit.asterisk.org/c/asterisk/+/13472 closed)
> error: failed to push some refs to 'ssh://<mya alias>@gerrit.asterisk.org:29418/asterisk.git'"
> Sorry for this fuss...

I've restored your this review and abandoned the other.  Should work now.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13472
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074
Gerrit-Change-Number: 13472
Gerrit-PatchSet: 1
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 16 Dec 2019 21:56:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191216/46ec8978/attachment.html>