[Asterisk-code-review] netsock2: Implementation for ast_sockaddr_from_sockaddr. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13361 )

Change subject: netsock2: Implementation for ast_sockaddr_from_sockaddr.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/13361/1/include/asterisk/netsock2.h 
File include/asterisk/netsock2.h:

https://gerrit.asterisk.org/c/asterisk/+/13361/1/include/asterisk/netsock2.h@731 
PS1, Line 731:  * \brief Converts a struct sockaddr_in to a struct ast_sockaddr.
This is incorrect as it's a struct sockaddr


https://gerrit.asterisk.org/c/asterisk/+/13361/1/include/asterisk/netsock2.h@738 
PS1, Line 738:  * \param sin The sockaddr_in to convert
Ditto here


https://gerrit.asterisk.org/c/asterisk/+/13361/1/main/netsock2.c 
File main/netsock2.c:

https://gerrit.asterisk.org/c/asterisk/+/13361/1/main/netsock2.c@696 
PS1, Line 696: 	if (addr->len)
We still enclose these with { and }



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13361
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iee604e96e9096c79b477d6e5ff310cf0b06dae86
Gerrit-Change-Number: 13361
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 09 Dec 2019 12:40:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191209/b9dfa372/attachment.html>