[Asterisk-code-review] PJSIP_CONTACT: add missing argument documentation (asterisk[16])

Friendly Automation asteriskteam at digium.com
Wed Dec 4 18:33:40 CST 2019


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/13230 )

Change subject: PJSIP_CONTACT: add missing argument documentation
......................................................................

PJSIP_CONTACT: add missing argument documentation

add missing argument "rtt" and "status" to the documentation

ASTERISK-28626
Change-Id: I8419e4c8203e411b87d93dc395acdbcf7526dedf
---
M doc/appdocsxml.dtd
M funcs/func_pjsip_contact.c
2 files changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/doc/appdocsxml.dtd b/doc/appdocsxml.dtd
index 21f1b9d..9f00ee5 100644
--- a/doc/appdocsxml.dtd
+++ b/doc/appdocsxml.dtd
@@ -110,7 +110,7 @@
   <!ATTLIST option implies CDATA "">
   <!ATTLIST option hasparams CDATA "">
 
-  <!ELEMENT enumlist (configOptionToEnum|enum+)>
+  <!ELEMENT enumlist (configOptionToEnum|(configOptionToEnum,enum+)|enum+)>
   <!ELEMENT enum (para|note|warning|parameter|enumlist|info|xi:include)*>
   <!ATTLIST enum name CDATA "">
 
diff --git a/funcs/func_pjsip_contact.c b/funcs/func_pjsip_contact.c
index 91f2f77..9d4ba68 100644
--- a/funcs/func_pjsip_contact.c
+++ b/funcs/func_pjsip_contact.c
@@ -60,6 +60,12 @@
 					<configOptionToEnum>
 						<xi:include xpointer="xpointer(/docs/configInfo[@name='res_pjsip']/configFile[@name='pjsip.conf']/configObject[@name='contact']/configOption)"/>
 					</configOptionToEnum>
+					<enum name="rtt">
+						<para>The RTT of the last qualify</para>
+					</enum>
+					<enum name="status">
+						<para>Status of the contact</para>
+					</enum>
 				</enumlist>
 			</parameter>
 		</syntax>

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13230
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8419e4c8203e411b87d93dc395acdbcf7526dedf
Gerrit-Change-Number: 13230
Gerrit-PatchSet: 4
Gerrit-Owner: Pascal Cadotte Michaud <pcm at wazo.io>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191204/358683fa/attachment.html>


More information about the asterisk-code-review mailing list