[Asterisk-code-review] pjsip/dialplan_functions.c: Get dialable string from function. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13349 )

Change subject: pjsip/dialplan_functions.c: Get dialable string from function.
......................................................................


Patch Set 1:

Wouldn't it be better to make Dial tolerant of empty dial strings and empty list positions?
For example:
Dial(,20,g)
Dial(PJSIP/101&,20,g)
Dial(PJSIP/101&&PJSIP/102,20,g)

It would certainly simplify a lot of dialplan that has to check for these conditions.

If there winds up being no endpoints to dial then Dial continues in dialplan as if the endpoint didn't answer with DIALSTATUS set to NOANSWER or maybe a new value like NOENDPOINT or NODESTINATION.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13349
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1709ee211705edac4d93f55723b8153bb653a338
Gerrit-Change-Number: 13349
Gerrit-PatchSet: 1
Gerrit-Owner: cmaj <chris at penguinpbx.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 03 Dec 2019 22:37:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191203/14c8796c/attachment.html>