[Asterisk-code-review] func_odbc: acf_odbc_read() and cli_odbc_read() unicode support (...asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12812 )

Change subject: func_odbc:  acf_odbc_read() and cli_odbc_read() unicode support
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/12812/2/funcs/func_odbc.c 
File funcs/func_odbc.c:

https://gerrit.asterisk.org/#/c/12812/2/funcs/func_odbc.c@932 
PS2, Line 932: 				if ((coltype <= SQL_WCHAR) && (coltype >= SQL_WLONGVARCHAR)) {
This logic assumes that SQL_WCHAR and SQL_WLONGVARCHAR are negative and that what's between them (currently SQL_WVARCHAR) is also wide.  This may be true today but may not be in the future.  Instead, check for the 3 specific values...
(coltype == SQL_WCHAR || coltype == SQL_WVARCHAR || coltype == SQL_WLONGVARCHAR)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12812
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I50e86c8a277996f13d4a4b9b318ece0d60b279bf
Gerrit-Change-Number: 12812
Gerrit-PatchSet: 2
Gerrit-Owner: Boris P. Korzun <drtr0jan at yandex.ru>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 11:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190828/6e64f75a/attachment.html>