[Asterisk-code-review] ARI: External Media (...asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12775 )

Change subject: ARI: External Media
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > Patch Set 1:
> > > 
> > > (1 comment)
> > 
> > Wouldn't you then need to query individually for the channel variables? From a user perspective that is a bit unfriendly then just returning the data in a JSON payload when it is created, and reduces the number of round trips.
> 
> No because you get the ChannelVarset events which have the variables in them.

Oh yeah, there's also the possibility that at the time we send back the response, we don't have the additional information.  It might not be available until teh channel is actually "Up"


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12775
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I9618899198880b4c650354581b50c0401b58bc46
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 14:33:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190827/9cb81c40/attachment.html>