[Asterisk-code-review] dns_core: Create new API ast_dns_resolve_ipv6_and_ipv4 (...asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12766 )

Change subject: dns_core:  Create new API ast_dns_resolve_ipv6_and_ipv4
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/12766/4/main/dns_core.c 
File main/dns_core.c:

https://gerrit.asterisk.org/#/c/12766/4/main/dns_core.c@430 
PS4, Line 430: 				ast_log(LOG_ERROR, "Unrecognized rr_type '%u' or data_size '%zu' from DNS query for host '%s'\n",
> Would it be better to be more tolerant and skip in case there are multiple records where only one is wonky, but another is fine?

Good point



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12766
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I194b0b0e73da94b35cc35263a868ffac3a8d0a95
Gerrit-Change-Number: 12766
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 22 Aug 2019 11:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190822/63e18041/attachment.html>