[Asterisk-code-review] srtp: Fix possible race condition, and add NULL checks (...asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11698 )

Change subject: srtp: Fix possible race condition, and add NULL checks
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/11698/2/res/res_pjsip_sdp_rtp.c 
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/11698/2/res/res_pjsip_sdp_rtp.c@936 
PS2, Line 936: 		ast_log(LOG_WARNING, "Ignoring crypto offer with unsupported parameters: %s\n", crypto_str);
My concern with changing this to a warning is that this can happen and the call can still succeed, resulting in potential confusion for the user and reports of a problem when none exists. I believe this happen in chan_sip previously and thus it was changed there.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11698
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I240e11cbb1e9ea8083d59d50db069891228fe5cc
Gerrit-Change-Number: 11698
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 11:51:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190809/e7a2e267/attachment.html>