[Asterisk-code-review] res_pjsip: Channel variable SIPFROMDOMAIN (...asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11651 )

Change subject: res_pjsip: Channel variable SIPFROMDOMAIN
......................................................................


Patch Set 5:

(1 comment)

> Should I proceed with merge to master?

This review is already slated to go into master once approved. Once it receives a +2 code review, it will be automatically merged.

https://gerrit.asterisk.org/#/c/11651/4/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/11651/4/res/res_pjsip_session.c@a3470 
PS4, Line 3470: 
> When I enable "blame" function it says it is: 37b2e68 on 10/24/2018 by Nick French […]
The previous patchset that you uploaded DID remove those two lines. The current master branch has them:

https://github.com/asterisk/asterisk/blob/master/res/res_pjsip_session.c#L3446

And if you look at the previous patch sets on this review you will see that they were being removed. It's not a big deal as it has been corrected, but I'm not making things up :-)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11651
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I715133e43172ce2a1e82093538dc39f9e99e5f2e
Gerrit-Change-Number: 11651
Gerrit-PatchSet: 5
Gerrit-Owner: Stas Kobzar <stas at modulis.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Stas Kobzar <stas at modulis.ca>
Gerrit-Comment-Date: Fri, 02 Aug 2019 13:31:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stas Kobzar <stas at modulis.ca>
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190802/7c9da8f3/attachment.html>