[Asterisk-code-review] res_pjsip: Channel variable PJSIP_FROM_DOMAIN (...asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11651 )

Change subject: res_pjsip: Channel variable PJSIP_FROM_DOMAIN
......................................................................


Patch Set 2:

(3 comments)

See previous comments, probably best to use SIPFROMDOMAIN for consistency with other places in PJSIP land.

https://gerrit.asterisk.org/#/c/11651/2/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/11651/2/res/res_pjsip_session.c@a3446 
PS2, Line 3446: 
Eh?


https://gerrit.asterisk.org/#/c/11651/2/res/res_pjsip_session.c@a3470 
PS2, Line 3470: 
Eh?


https://gerrit.asterisk.org/#/c/11651/2/res/res_pjsip_session.c@1504 
PS2, Line 1504:   
Red blob



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11651
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I715133e43172ce2a1e82093538dc39f9e99e5f2e
Gerrit-Change-Number: 11651
Gerrit-PatchSet: 2
Gerrit-Owner: Stas Kobzar <stas at modulis.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 17:10:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190801/b6f2380d/attachment.html>