[Asterisk-code-review] res_pjsip: Channel variable SIPFROMDOMAIN (...asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11651 )

Change subject: res_pjsip: Channel variable SIPFROMDOMAIN
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> (1 comment)
> 
> I'm not a huge fan of using "magic variables" to change behavior in new code. Our goal with chan_pjsip is feature parity with chan_sip, not necessarily compatibility. If we _were_ to allow a channel variable to influence behavior, we should at least make it a variable name that we can live with long term, like PJSIP_FROM_DOMAIN.

Feel free to ignore all that. I checked and there are a few places in the PJSIP code that we decided to kick the can down the road (SIPREPLACESHDR and SIPREFERREDBYHDR). So using SIPFROMDOMAIN is fine.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11651
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I715133e43172ce2a1e82093538dc39f9e99e5f2e
Gerrit-Change-Number: 11651
Gerrit-PatchSet: 1
Gerrit-Owner: Stas Kobzar <stas at modulis.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 01 Aug 2019 13:06:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190801/482d61bb/attachment.html>