[Asterisk-code-review] res_remb_modifier: Propertly initialize bitrate to 0.0 (...asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11295 )

Change subject: res_remb_modifier:  Propertly initialize bitrate to 0.0
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11295/1/res/res_remb_modifier.c 
File res/res_remb_modifier.c:

https://gerrit.asterisk.org/#/c/11295/1/res/res_remb_modifier.c@a65 
PS1, Line 65: 
I think this is incomplete. I think if no bitrate is set the code should return the remb frame as-is. It was previously permitted for this to happen by setting bitrate to 0, which meant don't touch it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11295
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ib2175ab84f85a3d7060d31625f5a2c7fbcc2ba4c
Gerrit-Change-Number: 11295
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 19:50:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190417/32a034dd/attachment.html>