[Asterisk-code-review] main/stasis.c: Added detail info for stasis show app cli (...asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11253 )

Change subject: main/stasis.c: Added detail info for stasis show app cli
......................................................................


Patch Set 2:

(3 comments)

> Patch Set 1: Code-Review-1
> 
> (3 comments)

Hi Joshua,

Thank you for your kind review. :)

I've updated commit as your comment.

https://gerrit.asterisk.org/#/c/11253/1/main/stasis.c 
File main/stasis.c:

https://gerrit.asterisk.org/#/c/11253/1/main/stasis.c@2410 
PS1, Line 2410: 		ast_cli(a->fd, "  %s: %d: %s\n", subscription_tmp->uniqueid, subscription_tmp->topic->subscriber_id, subscription_tmp->topic->name);
> When outputting multiple bits of data what each column or field being displayed is should be stated, […]
Agree, added each column name and removed subscriber ID.


https://gerrit.asterisk.org/#/c/11253/1/main/stasis.c@2413 
PS1, Line 2413: 	ast_cli(a->fd, "\nSubscriptions:\n");
> This isn't accurate. These are topics being forwarded into this one.
Got it. Changed it to the Forwarded topic


https://gerrit.asterisk.org/#/c/11253/1/main/stasis.c@2416 
PS1, Line 2416: 		ast_cli(a->fd, "  %d: %s\n", topic_tmp->subscriber_id, topic_tmp->name);
> Subscriber ID is an internal field used for guaranteeing uniqueness for generated names.
Got it. I've rid of id field.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11253
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If25a6f14fe4f622bfb37462e891333da1fdf875f
Gerrit-Change-Number: 11253
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 16 Apr 2019 20:28:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190416/21babc89/attachment.html>