[Asterisk-code-review] app_voicemail: Don't split mailbox options on comma (...asterisk[16])
Friendly Automation
asteriskteam at digium.com
Tue Apr 16 11:36:28 CDT 2019
Friendly Automation has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/asterisk/+/11282 )
Change subject: app_voicemail: Don't split mailbox options on comma
......................................................................
app_voicemail: Don't split mailbox options on comma
Because the per-mailbox options are the last thing on a line, don't look
for or stomp on any subsequent commas.
ASTERISK-27935 #close
Reported by: Sébastien Duthil
Change-Id: I07b2eb4a33c303d0c7114d5b906f8c067c60a153
---
M apps/app_voicemail.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Benjamin Keith Ford: Looks good to me, but someone else must approve
Joshua Colp: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved
Friendly Automation: Approved for Submit
diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index 0e24731..5c06be7 100644
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -12531,8 +12531,8 @@
if (stringp && (s = strsep(&stringp, ","))) {
ast_copy_string(vmu->pager, s, sizeof(vmu->pager));
}
- if (stringp && (s = strsep(&stringp, ","))) {
- apply_options(vmu, s);
+ if (stringp) {
+ apply_options(vmu, stringp);
}
switch (vmu->passwordlocation) {
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11282
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I07b2eb4a33c303d0c7114d5b906f8c067c60a153
Gerrit-Change-Number: 11282
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190416/ba8d3ece/attachment-0001.html>
More information about the asterisk-code-review
mailing list