[Asterisk-code-review] chan_pjsip: DTMF Mode auto_info fallback lead to both inband and info (...asterisk[master])

[George Joseph]

George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/asterisk/+/11237 )

Change subject: chan_pjsip: DTMF Mode auto_info fallback lead to both inband and info
......................................................................

chan_pjsip: DTMF Mode auto_info fallback lead to both inband and info

When the dtmf_mode on an endpoint is configured as "auto_info"
Asterisk will produce an inband DTMF tone alongside an INFO
message when sending DTMF.

ASTERISK-28371

Change-Id: I1380b82f006e110a1b83fbb50c9873edd13a5d9a
---
M channels/chan_pjsip.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c
index 55cd9ed..e1b3b18 100644
--- a/channels/chan_pjsip.c
+++ b/channels/chan_pjsip.c
@@ -2016,7 +2016,7 @@
 		break;
 	case AST_SIP_DTMF_AUTO_INFO:
 		if (!media || !media->rtp || (ast_rtp_instance_dtmf_mode_get(media->rtp) == AST_RTP_DTMF_MODE_NONE)) {
-			return -1;
+			return 0;
 		}
 		ast_rtp_instance_dtmf_begin(media->rtp, digit);
 		break;

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11237
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1380b82f006e110a1b83fbb50c9873edd13a5d9a
Gerrit-Change-Number: 11237
Gerrit-PatchSet: 1
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190410/5f5b3edc/attachment.html>